Add getAllEntities to GetDeclarationListSymbols#841
Closed
nosami wants to merge 2 commits into
Closed
Conversation
Now that we can include all entities for top level completions, the grouping function can incorrectly group types with the same display name as function overloads. Use the compiled name instead as this includes the namespace.
This was referenced Dec 20, 2017
Contributor
|
Some kind of nuget issue on travis? Not sure if it is transient or not |
Member
Author
|
Did you restart the build? Looks like it's green now. |
Contributor
|
@nosami Should this go to visualfsharp? Or has it already been submitted there? thx |
Member
Author
|
@dsyme - I'll submit to visualfsharp |
Contributor
|
@nosami Thanks. I'll get the integrations started too |
Member
Author
|
Closing in favour of dotnet/fsharp#4204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the change that was made to GetDeclarationListInfo API to add a function that gets all entities to GetDeclarationListSymbols.
Also changed the overload grouping mechanism to include the namespace. Previously this was grouping on DisplayName only, but this doesn't work when you return multiple types with the same DisplayName.